Add YNotebook get_cell, set_cell, append_cell #35
Conversation
jupyter_ydoc/ydoc.py
Outdated
| def _put_cell(self, index: int, ycell: Y.YMap, txn): | ||
| if len(self._ycells) >= index + 1: | ||
| self._ycells.delete(txn, index) | ||
| self._ycells.insert(txn, index, ycell) |
There was a problem hiding this comment.
@Waidhoferj I'm not sure to understand the error message:
y_py.MultipleIntegrationError: Cannot integrate a nested Ypy object because is already integrated into a YDoc: {'source': YText(print('Hello, World!')), 'execution_count': None, 'metadata': YMap({}), 'outputs': YArray([]), 'id': None, 'cell_type': 'code'}
The YMap I'm trying to insert into a YArray is not part of a YDoc.
There was a problem hiding this comment.
My bad, I think it was on my side.
There was a problem hiding this comment.
Actually I think there is a bug in ypy. It doesn't happen in the CI, but locally I have the error above at this line.
There was a problem hiding this comment.
@Waidhoferj ypy HEAD doesn't seem to fix this one.
There was a problem hiding this comment.
@davidbrochart Having trouble reproducing the issue. I've run a couple tests pushing preliminary Y elements into an array.
def test_multiple_integration():
d = Y.YDoc()
wrapper = d.get_array("wrapper")
inner = Y.YMap({"foo": "bar"})
with d.begin_transaction() as txn:
wrapper.append(txn, inner) # I'd expect an error hereTried to set up the repository, but I'm having dependency issues related to ypy-websockets.
There was a problem hiding this comment.
I cannot reproduce the issue either.
Do you want to release ypy?
davidbrochart
force-pushed
the
get_set_cell
branch
from
6046a74 to
5c484fe
Compare
davidbrochart
changed the title
davidbrochart
force-pushed
the
get_set_cell
branch
2 times, most recently
from
1ade0ee to
e0409a1
Compare
davidbrochart
force-pushed
the
get_set_cell
branch
2 times, most recently
from
9256927 to
f9fe1c6
Compare
davidbrochart
force-pushed
the
get_set_cell
branch
from
f9fe1c6 to
35c3466
Compare
Fixes #34.