Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native kernel by default #36

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

blink1073
Copy link
Contributor

I ran a comparison of starting a kernel 10 times, executing, and shutting down. Here were the total times:

  • echo 24s
  • python3 8s
  • xpython 8s
  • xpython-raw 8s

So much for "echo" being faster. 😅

@blink1073 blink1073 added the enhancement New feature or request label Dec 6, 2022
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 94.52% // Head: 94.50% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8637dc2) compared to base (84573a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   94.52%   94.50%   -0.02%     
==========================================
  Files          12       12              
  Lines         511      510       -1     
==========================================
- Hits          483      482       -1     
  Misses         28       28              
Impacted Files Coverage Δ
pytest_jupyter/jupyter_server.py 93.22% <ø> (-0.06%) ⬇️
pytest_jupyter/jupyter_client.py 90.32% <100.00%> (+0.32%) ⬆️
tests/test_jupyter_client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit f870e46 into jupyter-server:main Dec 7, 2022
@blink1073 blink1073 deleted the change_default_kernel branch December 7, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants