update_mapped_classes fixes #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
reviewed
Jan 4, 2017
| set_button_style() { | ||
| var view = this; | ||
| var buttons = this.buttongroup.querySelectorAll('button'); | ||
| _.each(buttons, function(button) { |
There was a problem hiding this comment.
Use a () => {} function, and then just use this instead of view.
Sure, why not? |
|
Other than the conflict and the (minor) comment, this looks good to me. |
SylvainCorlay
force-pushed
the
mapped-classes
branch
from
befff96 to
605981c
Compare
SylvainCorlay
force-pushed
the
mapped-classes
branch
from
605981c to
0292839
Compare
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a fix to #946 .
The reason for that bug is when
ProgressView.renderis run,model.previous('bar_style')andmodel.get('bar_style')are both equal toinfo, so that the difference performed byupdate_classesis nil, and nothing gets applied.So what I did is create an extra
set_bar_stylewhich will make the difference with an empty list instead.For the non-mapped classes that can be applied, this is what the base
DOMWidgetViewwas doing.I made
class_mapa static variable in all the widget views that use one.In the case of
ButtonView, mapped classes and top-level element classes properties both edit the same class list, which causes conflicts. One way to solve this would be to move the button element down in the DOM. @jasongrout what do you think of this?