Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive.widget_from_abbrev should be a classmethod #1024

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Jan 5, 2017

All the widget_from_... methods can be called from the interactive class (without an instance) because they are static methods. The only exception is widget_from_abbrev (which calls the other methods). Fix this by making widget_from_abbrev a class method. Note that it cannot be a static method, since we need to call other methods.

@SylvainCorlay SylvainCorlay merged commit 77ab2f5 into jupyter-widgets:master Jan 6, 2017
@SylvainCorlay
Copy link
Member

Thanks, this makes perfect sense.

@jasongrout jasongrout modified the milestone: 6.0 Feb 28, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants