Revert dropdown control to use a native select control. #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are serious keyboard handling problems with the dropdown control (see jupyter-widgets#1049), and a lack of documentation for how the control behaves (see jupyter-widgets#1055). We revert to the native select control until we rectify both of these issues and split the UI control off to be a phosphor control which the widget wraps.
|
OK, but the plan is to still implement a phosphor widget version of the dropdown? |
That's why I left the current code/CSS in there - to be factored out. |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are serious keyboard handling problems with the dropdown control (see #1049), and a lack of documentation for how the control behaves (see #1055). We revert to the native select control until we rectify both of these issues and split the UI control off to be a phosphor control which the widget wraps.