Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear widget areas when output is cleared #1098

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Clear widget areas when output is cleared #1098

merged 1 commit into from
Feb 14, 2017

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Feb 10, 2017 •
edited
Loading

Fixes #637.

This was referenced Feb 10, 2017
Closed
Merged
@jasongrout
Copy link
Member Author

This needs jupyter/notebook#2173 in order to properly clear output areas.

@jasongrout
Clear widget areas when a cell output is cleared.
0b49d64 
This depends on adding the ‘clearOuput.CodeCell’ event to the notebook.

We also take this opportunity to refactor the event handlers so there are notebook-wide event handlers, rather than new event handlers for each cell.
@jasongrout
Copy link
Member Author

jasongrout commented Feb 14, 2017 •
edited
Loading

Rebased for the new event name (see jupyter/notebook#2173)

@jasongrout jasongrout merged commit 832f54f into jupyter-widgets:master Feb 14, 2017
@jasongrout jasongrout modified the milestone: 6.0 Feb 28, 2017
@marscher
Copy link

Just a stupid question, why is the widget not removed when we call close on the backend side? I seems like there are some left overs after closing (namely an empty div element in the dom).

@jasongrout
Copy link
Member Author

Great question. We discussed this also in #1845 -- basically it's a limitation of the notebook. However, I think #1845 (comment) points out a way we can get visually what we want without messing up the notebook.

Let's take the discussion to that issue so it's all in one place.

@marscher
Copy link

marscher commented Jan 16, 2018 via email

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Clear widgets when a cell's output is cleared in classic notebook
2 participants
@jasongrout @marscher