added _view_count trait to Widget, to count the number of views #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
reviewed
Apr 3, 2017
ipywidgets/widgets/widget.py
Outdated
| @@ -247,6 +247,8 @@ def get_view_spec(self): | |||
| help="Name of the view object.").tag(sync=True) | |||
| _view_module_version = Unicode('*', | |||
| help="A semver requirement for the view module version.").tag(sync=True) | |||
| _view_count = Int(read_only=True, | |||
| help="The number of views accociated to the model at the front-end").tag(sync=True) | |||
There was a problem hiding this comment.
"associated". Also, can we indicate this is experimental for now? Maybe "EXPERIMENTAL: The number of views of the model displayed in the frontend. This attribute is experimental and may change or be removed in the future."
jasongrout
reviewed
Apr 3, 2017
jupyter-js-widgets/src/widget.ts
Outdated
| @@ -623,6 +623,19 @@ abstract class WidgetView extends NativeView<WidgetModel> { | |||
| this.listenTo(this.model, 'change', this.update); | |||
|
|
|||
| this.options = parameters.options; | |||
|
|
|||
| this.once('remove', () => { | |||
| console.log("remove view count", this.model.get('_view_count'), this.model.get('_view_count') -1) | |||
jasongrout
reviewed
Apr 3, 2017
jupyter-js-widgets/src/widget.ts
Outdated
| }); | ||
|
|
||
| this.once('displayed', () => { | ||
| console.log("add view count", this.model.get('_view_count'), this.model.get('_view_count') +1) |
|
I assume you are ok with merging this, I'll add those comments and remove the logs. It would take some debugging to see why Output is misbehaving though, but that bug/feature can't be in this code I think. I hope to update this soon. |
Yes, I'm okay merging this as an experimental feature. |
|
Thanks again for pushing forward on things! |
|
Thanks! |
|
Looking forward to the next release ! :) |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added _view_count trait to Widget, to count the number of views in the backend, as discussed here: #1225
There seems to be an issue with the Output widget, it only sends it state once, subsequent calls to
OutputModel.save()orOutputModel.save_changes()do nothing. I'm not sure what is so different about OutputModel.I also noticed
WidgetView.remove()was called twice, I'll submit an issue for that, I've worked around that by using.once(..).