Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct use of save_changes and touch methods #1309

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

Ricyteach
Copy link
Contributor

@Ricyteach Ricyteach commented Apr 25, 2017

I have been trying for the past couple hours to save_changes() using the view object as shown on this page, but kept getting an error. Apparently this part of the API has been changed per this discussion:

https://github.com/jupyter-widgets/ipywidgets/issues/1052#issuecomment-274836038

I have attempted to correct the explanation for use of the save_changes method (it is to be used on the model, not the view) and have added a line with an explanation for use of the view touch method. Hopefully everything is accurate.

I have been trying to `save_changes()` using the view object and getting an error. Apparently this part of the API has been changed per this discussion: 

jupyter-widgets#1052 (comment)

I have attempted to correct the explanation for use of the `save_changes` method (it is to be used on the model, not the view) and add a line with an explanation for the view `touch` method. Hopefully everything is accurate.
@jasongrout
Copy link
Member

This looks great; thanks!

@jasongrout jasongrout merged commit f452016 into jupyter-widgets:master Apr 25, 2017
@jasongrout jasongrout added this to the 7.0 milestone Apr 25, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants