Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Don’t call the view general update method if just _view_count changes. #1334

Merged
merged 1 commit into from
May 5, 2017

Conversation

jasongrout
Copy link
Member

This may solve the issues we're having with _view_count changes in pythreejs causing infinite event trigger loops: jupyter-widgets/pythreejs#95

CC @maartenbreddels, @SylvainCorlay

@maartenbreddels
Copy link
Member

Ok, if this solves it I'm ok with it. But I did get annoyed by all the websocket msg'es flying around, making debugging difficult. So do you think we should have an opt-in option, where by default it shouldn't keep track of the _view_count, but only when a new property (say _record_view_count ) is set to True?

@jasongrout
Copy link
Member Author

But I did get annoyed by all the websocket msg'es flying around, making debugging difficult.

True, it doesn't solve that issue.

but only when a new property (say _record_view_count) is set to True?

I guess we get some weird semantics if the record attribute is set after views are created. Another thing we could do is to let _view_count be None, and if it is None (i.e., null), then don't update it.

@SylvainCorlay
Copy link
Member

This looks good to me.

@SylvainCorlay SylvainCorlay merged commit 2727bc0 into jupyter-widgets:master May 5, 2017
@jasongrout jasongrout modified the milestone: 7.0 May 15, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants