[WIP] Docs for new embed package #1397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbugnion
force-pushed
the
docs-for-new-embed-package
branch
from
bb50573 to
8e4efb7
Compare
|
Thanks! With all of the package changes, we're going to have to tweak the wording now. I've now published the package to |
|
@pbugnion - what is the status of this? It looks like there probably needs to be a lot more revision given the recent changes. We can merge this and iterate, or continue revising here. |
|
This got somewhat left behind. I think the easiest is to close the PR. I'll keep the branch in my fork and revise it after my current PRs. If that makes sense, I'll let you close it? |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the documentation after PR #1394 and adds an example of embedding.