Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use window.requirejs instead of window.require which is overriden by the RTD theme #1943

Merged

Conversation

SylvainCorlay
Copy link
Member

No description provided.

@SylvainCorlay SylvainCorlay merged commit 79e964a into jupyter-widgets:master Jan 30, 2018
@SylvainCorlay SylvainCorlay deleted the requirejs-global branch January 30, 2018 16:27
@vidartf
Copy link
Member

vidartf commented Jan 30, 2018

So, this should mean we don't need this helper script for widget docs, right?

@vidartf
Copy link
Member

vidartf commented Jan 30, 2018

Also, for inter-linking: readthedocs/sphinx_rtd_theme#497

@maartenbreddels
Copy link
Member

Was wondering about that too. @vidartf this issue only showed up using the the rtd theme locally right?

@vidartf
Copy link
Member

vidartf commented Jan 30, 2018

@maartenbreddels yes

@SylvainCorlay
Copy link
Member Author

Right, I did not know about this helper.

@vidartf
Copy link
Member

vidartf commented Jan 30, 2018

Temporary workaround together with the code in doc config.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants