-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Jupyter Releaser #3298
base: main
Are you sure you want to change the base?
Prepare for Jupyter Releaser #3298
Conversation
82c5216
to
ef29522
Compare
The |
I ran "Draft Changelog" on my branch. From the logs, it looks like we would need to install JupyterLab in the draft-changelog action (because bump-version.py needs |
9eba0ff
to
24f20c1
Compare
Thanks @davidbrochart for starting this!
Or we use |
Actually I was missing some Jupyter Releaser hooks. But the problem is that the bump-version.py script needs |
Normally |
@davidbrochart let's convert the PR to a draft while we iterate on it |
For reference the current release instructions are in https://github.com/jupyter-widgets/ipywidgets/blob/master/docs/source/dev_release.md. And it looks like the versioning is done manually by running the Line 26 in 441135a
|
Edit: moving the TODO to the top comment. |
OK this is kind of weird. The check seems to be canceled sometimes after 1 minute, sometimes after 5. This one for instance: https://github.com/jupyter-widgets/ipywidgets/pull/3298/checks?check_run_id=3940082517 |
1 minute is probably because of ef786ca which removed the explicit install step. But it's strange that it is canceled instead of exiting on error. |
Isn't it because when |
Ah right, we are not using We can set it for now so it's easier to debug. |
3186c47
to
2f91eae
Compare
e2efa78
to
4b546f8
Compare
Closes #3285
TODO
8.0
bumpversion
/tbump
for bumping the Python packages? ->tbump
can be used for each of the Python packagesipywidgets
depending onjupyterlab_widgets
andwidgetsnbextension
:ipywidgets/setup.cfg
Lines 42 to 43 in 441135a