Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issue where npm isn't found on windows #21

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

gbivins
Copy link
Contributor

@gbivins gbivins commented Jun 26, 2017

This change adds 2 things

  1. Method to get a name for the npm command based on platform (windows vs others)
  2. Use the method to get the platform specific name for npm so that setup tools succeed

I tested on my generated widget code but I didn't see any other way to test this change.
If there is, I'd be more than happy to run them to verify the changes.

Fixes #20

@jasongrout jasongrout merged commit 51235d2 into jupyter-widgets:master Jul 20, 2017
@jasongrout
Copy link
Member

Thanks!

@gbivins
Copy link
Contributor Author

gbivins commented Sep 22, 2017

@jasongrout Just saw this! My first accepted PR on github outside of my own repos 😄

@jasongrout
Copy link
Member

Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants