-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure __webpack_public_path__ for nbextension #38
Conversation
@jasongrout Does this look OK? |
I thought we wanted to get rid of it, can you explain why we would want to add it? |
You want to get rid of it for jupyterlab extensions, but you might need it for classic notebook extensions. |
The docstring describes it more fully. However, the concern mentioned there doesn't matter for lab, where everything is bundled (including static assets). |
In my recollection (might be a gitter chat) there was no use for this (any more?) |
There could be a use for it in the classic notebook. I don't know anyone actually using it. |
I think this change looks like it probably is okay, but I haven't tested it. |
We may want to check this on ipyleaflet wrt marker images. I think that we don't need it anymore though. |
The line in ipyleaflet is here: https://github.com/jupyter-widgets/ipyleaflet/blob/658b21564dffaa85941bf73d1875121786a6ff92/js/src/notebook.js |
It seems to be matching perfectly!
|
I know what the reason was I removed it in ipyvolume (and now also in ipywebrtc) |
C.f. #37