Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure __webpack_public_path__ for nbextension #38

Merged
merged 1 commit into from
May 25, 2018

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Apr 18, 2018

C.f. #37

@vidartf
Copy link
Member Author

vidartf commented May 24, 2018

@jasongrout Does this look OK?

@maartenbreddels
Copy link
Member

I thought we wanted to get rid of it, can you explain why we would want to add it?

@vidartf
Copy link
Member Author

vidartf commented May 24, 2018

You want to get rid of it for jupyterlab extensions, but you might need it for classic notebook extensions.

@vidartf
Copy link
Member Author

vidartf commented May 24, 2018

The docstring describes it more fully. However, the concern mentioned there doesn't matter for lab, where everything is bundled (including static assets).

@maartenbreddels
Copy link
Member

In my recollection (might be a gitter chat) there was no use for this (any more?)

@jasongrout
Copy link
Member

There could be a use for it in the classic notebook. I don't know anyone actually using it.

@jasongrout
Copy link
Member

I think this change looks like it probably is okay, but I haven't tested it.

@SylvainCorlay
Copy link
Member

We may want to check this on ipyleaflet wrt marker images. I think that we don't need it anymore though.

@vidartf
Copy link
Member Author

vidartf commented May 25, 2018

@SylvainCorlay
Copy link
Member

SylvainCorlay commented May 25, 2018 via email

@SylvainCorlay SylvainCorlay merged commit 0aa620e into jupyter-widgets:master May 25, 2018
@vidartf vidartf deleted the patch-2 branch May 25, 2018 16:10
@maartenbreddels
Copy link
Member

I know what the reason was I removed it in ipyvolume (and now also in ipywebrtc)
I include the index.js for the Jupyter Lab extension, and that causes all widgets to fail without any error msg. This caused me quite some time to figure out again, so I though I should write it down at least somewhere. Sigh.. but, ipywebrtc in Jupyter Lab is working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants