-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging to use more modern python practices #87
Conversation
CC @ibdafna |
34416b5
to
a320cd6
Compare
Also, it's unfortunate that the pyproject.toml cannot say that nodejs or yarn are required :(. I realize this is a complication from us building a package that spans two packaging ecosystems, of course. |
This is because of this bug in So this PR is stalled until at least that bug is fixed and released. |
That bug was fixed and released yesterday 🚀 |
- added headings and code blocks in first half - `git clean -fdxn` shows files for deletion first, to avoid deleting important files on accident - `cd js` to move to the right directory for npm first - `npm login` is necessary for npm publish
This updates the cookiecutter to use setup.cfg, etc. See https://setuptools.readthedocs.io/en/latest/build_meta.html
To generate a wheel, I think recommended practice to now use
python -m build
, for example.warning package.json: No license field