Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging to use more modern python practices #87

Merged
merged 14 commits into from
Aug 16, 2022

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Feb 2, 2021

This updates the cookiecutter to use setup.cfg, etc. See https://setuptools.readthedocs.io/en/latest/build_meta.html

To generate a wheel, I think recommended practice to now use python -m build, for example.

  • Add install.json for the jlab extension
  • Error: warning package.json: No license field

@jasongrout
Copy link
Member Author

CC @ibdafna

@jasongrout jasongrout force-pushed the packaging branch 2 times, most recently from 34416b5 to a320cd6 Compare February 2, 2021 05:21
@jasongrout
Copy link
Member Author

jasongrout commented Feb 2, 2021

python -m build doesn't currently work because yarn cannot find jupyter labextension build - perhaps somehow a consequence of the virtual env the build process sets up? python -m build --no-isolation does work if the build dependencies are installed.

Also, it's unfortunate that the pyproject.toml cannot say that nodejs or yarn are required :(. I realize this is a complication from us building a package that spans two packaging ecosystems, of course.

@jasongrout
Copy link
Member Author

python -m build doesn't currently work because yarn cannot find jupyter labextension build - perhaps somehow a consequence of the virtual env the build process sets up? python -m build --no-isolation does work if the build dependencies are installed.

This is because of this bug in build: pypa/build#214

So this PR is stalled until at least that bug is fixed and released.

@vidartf
Copy link
Member

vidartf commented Feb 8, 2021

That bug was fixed and released yesterday 🚀

- added headings and code blocks in first half
- `git clean -fdxn` shows files for deletion first, to avoid deleting important files on accident
- `cd js` to move to the right directory for npm first
- `npm login` is necessary for npm publish
@jasongrout jasongrout marked this pull request as ready for review August 9, 2022 07:53
@jasongrout jasongrout requested a review from ibdafna August 9, 2022 07:55
@jasongrout jasongrout requested a review from vidartf August 16, 2022 07:49
@vidartf vidartf merged commit 6134771 into jupyter-widgets:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants