Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved xauthentication.hpp and xzmq_serializer.hpp to src folder #45

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Moved xauthentication.hpp and xzmq_serializer.hpp to src folder #45

merged 1 commit into from
Apr 12, 2024

Conversation

JohanMabille
Copy link
Member

No description provided.

anutosh491
anutosh491 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the faulty include leading to the build error should be addressed.

@JohanMabille JohanMabille force-pushed the isolation branch 2 times, most recently from 3357601 to c11cc62 Compare April 12, 2024 06:50
@JohanMabille JohanMabille merged commit c4cf0b7 into jupyter-xeus:main Apr 12, 2024
8 checks passed
@JohanMabille JohanMabille deleted the isolation branch April 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anutosh491 anutosh491 anutosh491 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanMabille @anutosh491