Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google season of docs 2023 proposal #120

Closed
wants to merge 4 commits into from

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Mar 22, 2023

This PR adds the proposal for Google Season of Docs 2023.

It includes all the sections defined in the template: https://developers.google.com/season-of-docs/docs/org-proposal-template


📚 Documentation preview 📚: https://jupyter-accessibility--120.org.readthedocs.build/en/120/

@gabalafou
Copy link
Collaborator

Copy link
Contributor

@isabela-pf isabela-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this so we can keep track of funding proposals related to Jupyter accessibility efforts!

I only have one question: would it be helpful to add links to some of the project descriptions and similar areas? This is not a blocker for me to merge it, but I did want to ask because I can add that.

I'll leave this up for review until Wednesday so that people have a little more time to review, but the proposal is also up before the deadline. I'll merge it then! Thanks again for leading this!

Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a number of questions and suggestions, but this seems in a good place.

Echoing @isabela-pf it would be best to add some more links to projects for whoever reviews this (esp. if not super familiar with the project(

docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
docs/funding/google-season-of-docs-2023.md Outdated Show resolved Hide resolved
@trallard trallard added the PR: changes requested 🏗 This PR has been reviewed and needs changes label Mar 28, 2023
steff456 and others added 2 commits March 28, 2023 11:38
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@steff456
Copy link
Contributor Author

Sorry everyone, I'm not sure how I mixed the dates up and thought the deadline was the 31st and not the 24th. I'm closing this PR for now, will re-open when we have a new grant to submit this project to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: changes requested 🏗 This PR has been reviewed and needs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants