Skip to content
This repository has been archived by the owner on Mar 4, 2018. It is now read-only.

Dockerfile: update IHaskell #105

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Dockerfile: update IHaskell #105

merged 2 commits into from
Jan 8, 2018

Conversation

vaibhavsagar
Copy link
Contributor

This bumps the versions of Haskell packages for IHaskell, and seems to work when I do make dev. Comments, suggestions, and improvements appreciated, especially the part where I change the user to root to install the IHaskell kernel.

@Carreau
Copy link
Member

Carreau commented Jan 7, 2018

it looks like

-USER root
-
-RUN ihaskell install && \
+RUN ihaskell install --prefix=$CONDA_DIR/share/jupyter/kernels/ && \
     rm -fr $(echo ~/.cabal/bin/* | grep -iv ihaskell) ~/.cabal/packages ~/.cabal/share/doc ~/.cabal/setup-exe-cache ~/.cabal/logs

-USER $NB_USER
-

Solve the permission issue, or at least install the kernelspec in a location which is user writable.

OMG this image takes forever to compile !

@Carreau
Copy link
Member

Carreau commented Jan 7, 2018

Spoke too soon, the command raise no error, but does nothing apparently.

@Carreau
Copy link
Member

Carreau commented Jan 7, 2018

My Bad --prefix=$CONDA_DIR should be enough, and the kernel works wth that. The notebook itself seem to have errors... but I'm not a haskeller.

Let me know if you prefer the root method or the --prefix method and we can merge this.

@vaibhavsagar
Copy link
Contributor Author

The --prefix=$CONDA_DIR method seems preferable, and I've updated my PR accordingly. I didn't know that the sample notebook had errors though, let me build the image again and see if it needs to be fixed on our end or in the Dockerfile. Would you prefer a second PR for that or should I roll those changes (if any) into this one?

@vaibhavsagar
Copy link
Contributor Author

vaibhavsagar commented Jan 8, 2018

Okay, I rebuilt it but now the kernel isn't installed (doesn't show up in the list of available kernels for me to choose from). I didn't realise the prefix had to be $CONDA_DIR. Now to rebuild again 😅.

@vaibhavsagar
Copy link
Contributor Author

I think I've fixed the error in the introductory notebook, let me know if you'd like me to split that out into a separate PR 😃.

@Carreau
Copy link
Member

Carreau commented Jan 8, 2018

Okay, I rebuilt it but now the kernel isn't installed (doesn't show up in the list of available kernels for me to choose from)

That is weird it workd for me yesterday. I'll check.

@Carreau
Copy link
Member

Carreau commented Jan 8, 2018

With the current state of the PR I see the IHaskell kernel, and I can run the notebook, So Im going to merge and would happily get other PRs to have extra fixes if it does not suits you.

Thanks !

@Carreau Carreau merged commit 100a5b2 into jupyter:master Jan 8, 2018
@vaibhavsagar vaibhavsagar deleted the update-ihaskell branch January 8, 2018 12:20
@vaibhavsagar
Copy link
Contributor Author

Thanks for your help!

@Carreau
Copy link
Member

Carreau commented Jan 8, 2018

Thanks for maintaining IHaskell !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants