Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mamba 2.0 #2147

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Install mamba 2.0 #2147

wants to merge 9 commits into from

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Oct 1, 2024

Describe your changes

Issue ticket if applicable

Fix: #2146

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Oct 1, 2024

The following argument was not expected: --no-builds

We use it here:

cmd = ["mamba", "env", "export", "-n", "base", "--json", "--no-builds"]

@JohanMabille I created an upstream issue: mamba-org/mamba#3492

UPDATE: I fixed this one by not using --json and using --no-build flag, which works for both v1 and v2

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Oct 1, 2024

Also: bash: line 1: conda: command not found

It seems that conda executable is now missing

I don't know if this is expected or not and the best way to fix this.

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Oct 3, 2024

Fixed this issue with the output of mamba list --full-name (it now works in mamba v2, but the output format has slightly changed, not a bug).
Also fixed an issue with mamba env export (reported to the upstream, but we no longer need it to be fixed).
And I did it in a way that works with both mamba v1 and v2.

The only remaining issue is with the missing conda executable.
We use it like this in 2 places: eval "$(conda shell.bash hook)".
As far as I see, the conda package is no longer installed when installing mamba, and that's why executable is missing.
And if I try to install it manually, it downgrades mamba to v1.

We can try to switch to eval "$(mamba shell hook)", but this is not something I would really like to do:

  1. I assume many of our users have conda install/activate commands in the images based on our images. Not having a conda executable will break them.
  2. We have some documentation ourselves suggesting using conda - this will also silently break.
  3. mamba shell hook doesn't exist in mamba v1, as far as I understand. This means we will make it difficult for users who fork our repo to stay with mamba v1 if they are not ready to upgrade yet.

So, we should probably wait till we can install both conda and mamba v2 simultaneously.

@jjerphan
Copy link

jjerphan commented Oct 8, 2024

Hi Ayaz,

Regarding failing update due to conda, you might want to track mamba-org/mamba#3503.

@mathbunnyru mathbunnyru mentioned this pull request Oct 23, 2024
4 tasks
@mathbunnyru mathbunnyru added the tag:Upstream A problem with one of the upstream packages installed in the docker images label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Upstream A problem with one of the upstream packages installed in the docker images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker stacks foundation image build fails with current mamba
2 participants