-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert latest changes to ThreadedZMQSocketChannel
because they break Qtconsole
#803
Conversation
ccordoba12
commented
Jun 8, 2022
•
edited
Loading
edited
- Those changes were done in commit 0057186, released in version 7.3.2.
- They break Qtconsole and hence Spyder, but I checked locally that a simple revert fixes the problem.
- I added the qtconsole test suite here to avoid future breakages.
100151f
to
f7c7673
Compare
f7c7673
to
3c6fc38
Compare
@blink1073, this is ready for review. As you can see, the Qtconsole test suite passes with these changes (you can check that it dies with Jupyter-client 7.3.3). Note: I don't know how to fix the MyPy error, so I need help with that. |
ThreadedZMQSocketChannel
because they break Qtconsole
Hi @ccordoba12, I think this might be an error in the typings in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for adding the qtconsole test!
Docs failure is unrelated, I'll pick that up in a separate PR. |
Great! Thanks for your help with that.
No prob. Jupyter-client is critical for us, so that's something we really needed to do (I'll do the same in IPykernel once I have some time). |
I'll cut a release once I merge #804 |
Thanks @blink1073 and @ccordoba12 for taking care of that. |