Fix DeprecationWarning with patched python-json-logger #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running tests with https://github.com/nhairs/python-json-logger 3.1.0 produces: DeprecationWarning: pythonjsonlogger.jsonlogger has been moved to pythonjsonlogger.json It's easy enough to be compatible with both.
for more information, see https://pre-commit.ci
Carreau
force-pushed
the
jsonlogger-deprecation
branch
from
e692ff5 to
e4bbaf5
Compare
Carreau
force-pushed
the
jsonlogger-deprecation
branch
from
4f32aa1 to
eab9ba8
Compare
|
I don't know who is responsible for this repo, but will try to do what I can to push things a bit forward. |
|
I will also bump min supported version to 3.9. |
|
Wow, after a long battle, test are passing; merging. |
bollwyvl
reviewed
Dec 18, 2024
|
|
||
| from jsonschema import ValidationError | ||
| from pythonjsonlogger import jsonlogger | ||
| from packaging.version import parse |
There was a problem hiding this comment.
this is a novel (though common) dependency: we'll probably ship it on conda-forge with it added, but will PR up as well.
There was a problem hiding this comment.
Ah, yes. Thanks for catching that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests with https://github.com/nhairs/python-json-logger 3.1.0 produces:
DeprecationWarning: pythonjsonlogger.jsonlogger has been moved to pythonjsonlogger.json
It's easy enough to be compatible with both.