Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Jep #65 #134

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Add test for Jep #65 #134

merged 5 commits into from
Aug 29, 2023

Conversation

Hind-M
Copy link
Contributor

@Hind-M Hind-M commented Jul 11, 2023

@Hind-M Hind-M marked this pull request as draft July 11, 2023 16:22
@Hind-M
Copy link
Contributor Author

Hind-M commented Jul 11, 2023

I guess the label should be enhancement to avoid the corresponding CI failure? I am not allowed to add it though.

@Hind-M Hind-M marked this pull request as ready for review August 22, 2023 09:01
@Hind-M
Copy link
Contributor Author

Hind-M commented Aug 29, 2023

Just a reminder to kindly ask for a review :) (Couldn't do it using GH)
Maybe @blink1073 is the right person here?
Thanks!

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 78b8f14 into jupyter:main Aug 29, 2023
19 checks passed
@Hind-M Hind-M deleted the xpub branch August 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants