Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest Selenium API #115

Closed
echarles opened this issue Jun 27, 2022 · 5 comments
Closed

Update to latest Selenium API #115

echarles opened this issue Jun 27, 2022 · 5 comments

Comments

@echarles
Copy link
Member

All selenium tests are failing on main branch, see #114

cc/ @RRosio @ericsnekbytes
@jtpio
Copy link
Member

jtpio commented Jun 28, 2022

FYI this is likely related to the latest 4.3.0 release of selenium and the removal of deprecated methods.

Also noticed in jupyter/nbgrader#1612

@echarles
Copy link
Member Author

yep just pined selenium and it is much better.

@echarles
Copy link
Member Author

#114 is ready for review. It pins selenium. We can leave this issue open to plan an removal of the selenium deprecated APIs.

@jtpio
Copy link
Member

jtpio commented Jun 28, 2022

Their docstrings say:

Please use find_element(by=By.CSS_SELECTOR, value=css_selector) instead",

So maybe worth trying to update to the new methods?

@echarles echarles changed the title Selenium tests are failing on main branch Update to latest Selenium API Jun 29, 2022
@echarles echarles mentioned this issue Jun 29, 2022
Merged
@echarles
Copy link
Member Author

The Selenium tests are being ported to Playwright in #139

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@echarles @jtpio