Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on nbextensions are broken with latest selenium version (4.3.0) #1612

Closed
brichet opened this issue Jun 24, 2022 · 2 comments
Closed

Tests on nbextensions are broken with latest selenium version (4.3.0) #1612

brichet opened this issue Jun 24, 2022 · 2 comments

Comments

@brichet
Copy link
Contributor

brichet commented Jun 24, 2022

The latest version of selenium 4.3.0 breaks the nbextensions tests with the following error :
E AttributeError: 'WebDriver' object has no attribute 'find_elements_by_css_selector'

This has been fixed in main branch in #1611 by pinning selenium < 4.3, as the main branch is no longer supposed to support nbextensions.

This issue should be fixed in the branch 0.7.x.

@jtpio
Copy link
Member

jtpio commented Jun 27, 2022

This seems to be related to the removal of previously deprecated methods:

  • Deprecated find_element_by_* and find_elements_by_* are now removed (#10712)

https://github.com/SeleniumHQ/selenium/blob/2fbfc62f565026ba57cf700e14179012c6ebef4c/py/CHANGES#L2

Probably we can remove the pin and update the code to the new API as mentioned in the docstring:

Please use find_element(by=By.CSS_SELECTOR, value=css_selector) instead",

@brichet
Copy link
Contributor Author

brichet commented Oct 7, 2022

Fixed in #1677

@brichet brichet closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants