Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes selenium tests #1677

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fixes selenium tests #1677

merged 1 commit into from
Sep 30, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 30, 2022 •
edited
Loading

EDIT : Fix #1612

All the methods like find_element_by_* and find_elements_by_* have been removed from selenium 4.3.0.

This PR replaces them by find_element(By.*, ...) and find_elements(By.*, ...).

@brichet
Copy link
Contributor Author

brichet commented Sep 30, 2022

@meeseeksdev backport to main

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 30, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/nbgrader that referenced this pull request Sep 30, 2022
@brichet @meeseeksmachine
Backport PR jupyter#1677: Fixes selenium tests
839fa5a
@brichet brichet requested a review from jtpio September 30, 2022 12:34
jtpio
jtpio approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Looks like this should fix #1612? If so then probably the pin added in #1611 can be removed?

@brichet
Copy link
Contributor Author

brichet commented Sep 30, 2022

Looks like this should fix #1612?

Yes, forgot to mention it.

If so then probably the pin added in #1611 can be removed?

It was not ported on this branch (0.7.x), only on main, but I'm backporting these changes on main and will remove the pin.

@jtpio
Copy link
Member

jtpio commented Sep 30, 2022

It was not ported on this branch (0.7.x), only on main, but I'm backporting these changes on main and will remove the pin.

Ah right, sounds good 👍

@brichet brichet mentioned this pull request Sep 30, 2022
Merged
@brichet brichet merged commit ebcee2d into 0.7.x Sep 30, 2022
@brichet brichet deleted the fix/selenium_tests branch September 30, 2022 13:33
brichet added a commit that referenced this pull request Oct 3, 2022
@brichet
Backport PR #1677: Fixes selenium tests
d84e49c
@brichet brichet mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brichet @jtpio