Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of the Linux JS Tests / Notebook and Base Test Failures in CI Job #103

Merged
merged 3 commits into from
May 24, 2022
Merged

Fix part of the Linux JS Tests / Notebook and Base Test Failures in CI Job #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3371d7d
updated import of IPython display module, import from core now deprec…
RRosio May 24, 2022
b0233a5
importing __version__ into init file to make it available for base/mi…
RRosio May 24, 2022
f6a14a4
update module name from notebook to nbclassic for base test
RRosio May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nbclassic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import os
from ._version import __version__

# Packagers: modify this line if you store the notebook static files elsewhere
DEFAULT_STATIC_FILES_PATH = os.path.join(os.path.dirname(__file__), "static")

Expand Down
2 changes: 1 addition & 1 deletion nbclassic/tests/base/misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
casper.notebook_test(function () {
var jsver = this.evaluate(function () {
var cell = IPython.notebook.get_cell(0);
cell.set_text('import notebook; print(notebook.__version__)');
cell.set_text('import nbclassic; print(nbclassic.__version__)');
cell.execute();
return IPython.version;
});
Expand Down
4 changes: 2 additions & 2 deletions nbclassic/tests/notebook/roundtrip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ casper.notebook_test(function () {

this.then(function() {
clear_and_execute(this,
"from IPython.core.display import SVG; SVG(" + svg + ")");
"from IPython.display import SVG; SVG(" + svg + ")");
});

this.then(function ( ) {
Expand All @@ -216,7 +216,7 @@ casper.notebook_test(function () {

this.then(function() {
clear_and_execute(this,
"from IPython.core.display import SVG, display; display(SVG(" + svg + "))");
"from IPython.display import SVG, display; display(SVG(" + svg + "))");
});

this.then(function ( ) {
Expand Down