Allow NBClassic to work with NB7 and ServerApp.base_url #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, upgrade to Notebook v7 and Lab v4, install this NBClassic, set ServerApp.base_url, run Jupyter, visit nbclassic
Also resolves an issue where New->New Notebook did not add the "/nbclassic/" in the url when Notebook v7 was installed
Personally not a fan of the var still being called base_url_prefix but I didn't want to change that unilaterally.
Closes #164