Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright Testing Conversion #170

Merged
merged 199 commits into from
Oct 22, 2022

Conversation

ericsnekbytes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes commented Oct 21, 2022

Converts frontend testing to a new/refactored framework based on playwright, and removes the old selenium tests.

  • Tests are now at nbclassic/tests/end_to_end
  • The utility layer and public testing framework, based on playwright, is contained utils.py
    • NotebookFrontend
    • FrontendElement
  • Pytest fixtures for obtaining browser instances, the jupyter server etc, are contained in conftest.py
  • Some minor issues with flakiness remain, but at present this is a substantial improvement over the old selenium tests

@echarles echarles added the enhancement New feature or request label Oct 21, 2022
@ericsnekbytes ericsnekbytes changed the title DRAFT Playwright Testing Conversion Playwright Testing Conversion Oct 21, 2022
@ericsnekbytes ericsnekbytes marked this pull request as ready for review October 21, 2022 18:42
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants