Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle async and sync contents managers #172

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073 blink1073 added the bug Something isn't working label Nov 2, 2022
@echarles
Copy link
Member

echarles commented Nov 2, 2022

Thx @blink1073. I will have a look at this tomorrow.

btw is the intent the same as #53?

@blink1073
Copy link
Contributor Author

The intent is the same, yes. I opened this because we're changing the default contents manager to be async in Jupyter Server 2 and the downstream test for nbclassic was failing. cf jupyter-server/jupyter_server#1044

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @blink1073

@echarles echarles merged commit 6fc4890 into jupyter:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants