Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Test Fixes Round 5 #232

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

ericsnekbytes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes commented Mar 6, 2023

Complete rewrite for test_dualmode_arrows:

  • Test command mode arrow functionality by pressing related arrow keys and checking the selection state of the cell, INSTEAD OF editing the cell and then checking that the output of all cells matches an expected value
  • Test edit mode arrow functionality by following the high level approach used in the selenium tests (up arrows in edit mode on empty cells jumps to cell above, etc.)

@ericsnekbytes ericsnekbytes changed the title Rewrite/refactors for test_dualmode_arrows. CI Test Fixes Round 5 Mar 6, 2023
@ericsnekbytes ericsnekbytes added bug Something isn't working maintenance labels Mar 6, 2023
@ericsnekbytes ericsnekbytes marked this pull request as ready for review March 6, 2023 21:01
@RRosio RRosio merged commit be4cb63 into jupyter:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants