Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Test Fixed Round6a #234

Merged
merged 3 commits into from
Mar 10, 2023
Merged

CI Test Fixed Round6a #234

merged 3 commits into from
Mar 10, 2023

Conversation

ericsnekbytes
Copy link
Collaborator

Complete rewrite for test_dashboard_navigation:

  • Cleaner, simpler test logic
  • Added state checks/retries for failure prone sections

@ericsnekbytes ericsnekbytes added bug Something isn't working maintenance labels Mar 10, 2023
@ericsnekbytes ericsnekbytes marked this pull request as ready for review March 10, 2023 16:46
@RRosio
Copy link
Collaborator

RRosio commented Mar 10, 2023

Thanks @ericsnekbytes!

@RRosio RRosio merged commit f237e24 into jupyter:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRosio RRosio Awaiting requested review from RRosio

Assignees
No one assigned
Labels
bug Something isn't working maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnekbytes @RRosio