Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State the correct name of the application in the desktop entry #244

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

befeleme
Copy link
Contributor

@befeleme befeleme commented Apr 17, 2023

In Fedora, we use the desktop file to generate the application entry in the graphical environment. Currently, both Notebook and NbClassic are propagated as "Jupyter Notebook" which is misleading. Changing the name and comment will make the displayed output easily recognizable.
cc @frenzymadness

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echarles echarles merged commit be4be5b into jupyter:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants