Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make terminals_available false if key is not in settings dict yet #261

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Make terminals_available false if key is not in settings dict yet #261

merged 1 commit into from
Aug 11, 2023

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Aug 10, 2023

Partial fix for #255 identified by @defjaf

@jtpio jtpio added the bug Something isn't working label Aug 11, 2023
jtpio
jtpio approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Not sure the CI failures are related (some checks are also failing with #259).

@RRosio
Copy link
Collaborator Author

RRosio commented Aug 11, 2023

Not sure the CI failures are related (some checks are also failing with #259).

I recently took a look at these CI failures for another PR as well as here and I agree that they don't seem to be related!
I will go ahead and merge this. Thank you for taking a look @jtpio!

@RRosio RRosio merged commit 759fa31 into jupyter:main Aug 11, 2023
22 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RRosio @jtpio