Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test nbconvert 5.6.1 with jupyter-client 6.2.0 #1550

Closed
wants to merge 1 commit into from

Conversation

mriedem
Copy link
Contributor

@mriedem mriedem commented Apr 12, 2021

@mriedem mriedem mentioned this pull request Apr 13, 2021
@mriedem
Copy link
Contributor Author

mriedem commented Apr 13, 2021

Recreated:

https://travis-ci.org/github/jupyter/nbconvert/jobs/766808690#L1370

self = <nbconvert.preprocessors.execute.ExecutePreprocessor object at 0x7f3e7ca1dd30>

msg_id = '238d6f9e-e6ea4495439b51dfd5175f5b_1'

cell = {'cell_type': 'code', 'metadata': {}, 'outputs': [], 'source': 'from __future__ import print_function\nfrom IPython.display import clear_output'}

timeout = 1

    def _poll_for_reply(self, msg_id, cell=None, timeout=None):

        try:

            # check with timeout if kernel is still alive

            msg = self.kc.shell_channel.get_msg(timeout=timeout)

>           if msg['parent_header'].get('msg_id') == msg_id:

E           TypeError: 'coroutine' object is not subscriptable

@SylvainCorlay
Copy link
Member

Hey, thank you for the contribution. I am confused by why we would test against a version of jupyter-client that has been yanked from PyPI.

@mriedem
Copy link
Contributor Author

mriedem commented Nov 15, 2021

Hey, thank you for the contribution. I am confused by why we would test against a version of jupyter-client that has been yanked from PyPI.

This was just showing a recreate of a failure. I'll close it.

@mriedem mriedem closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants