-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mermaidjs 10.2.3 #1957
Add mermaidjs 10.2.3 #1957
Conversation
for more information, see https://pre-commit.ci
Will look into the failing tests. |
Nice to see this happen, we also have support for mermaid in solara, so we will keep an eye on this and see if we can track the same version number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Cool. Over on the Lab PR I'll be working on bringing across more of the accessibility features, and will update here as appropriate. Perhaps we'll be able to eventually reuse some of the code/style which are already highly shared, and provide a clean, offline files-on-disk install/deployment with e.g. |
thanks for the mermaid suport. It did not work for me out of the box wit reveal, but after changing from "plain" mermaid to mermaid js plugin it does work for me. please review my changes here.: Is this a sensible improvement? Or did i make a stupid mistake and the original solution would work if i made a slight change... Best regards, |
Adds mermaidjs diagram support, which is the most commonly-available, open source ascii-based diagram tool, supporting a large number of broadly-useful diagrams.
The motivation is that this syntax
```mermaid
is supported natively by a large number of existing platforms under a consistent syntax, most notably GitHub, which theoretically we track.References
Changes
<script type="module"
User-facing changes