Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make travis run all tests (not SKIPPED tests) #356

Merged
merged 12 commits into from
Aug 29, 2016
Merged

Make travis run all tests (not SKIPPED tests) #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
06fe733
Change PATH to include downloaded pandoc
jankatins Aug 10, 2016
26075c5
Install needed latex packages
jankatins Aug 10, 2016
cf8f218
Install inkscape for svg to pdf tests
jankatins Aug 10, 2016
2682cca
Change test to skip if xelatex is not available
jankatins Aug 10, 2016
8efad53
Include more latex packages
jankatins Aug 10, 2016
415b074
Also install latex fonts
jankatins Aug 10, 2016
1b29483
Install more fonts on travis
jankatins Aug 10, 2016
680346e
Use a newer ubuntu on travis
jankatins Aug 10, 2016
a143025
Add xcolor latex package on travis
jankatins Aug 10, 2016
fa2697e
Even more pdflatex -> xelatex skips
jankatins Aug 10, 2016
33fcd14
And the deb package for the ulem latex package
jankatins Aug 10, 2016
7e97c5e
Comment travis switch to a newer ubuntu
jankatins Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Use a newer travis environment:
# https://docs.travis-ci.com/user/trusty-ci-environment/
# needs these two lines:
sudo: required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that sudo: required is necessary in order to use trusty? If so, a comment to that effect would be good; hopefully that will change at some point in the future, and then we can stop requiring sudo again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Then I think this is fine, but I'm tired, so I'll leave it for others to have a look at in case I'm overlooking something.

dist: trusty

language: python
python:
- 3.5
Expand All @@ -6,12 +12,17 @@ python:
- 2.7
env:
global:
- PATH=$TRAVIS_BUILD_DIR/pandoc:$PATH
sudo: false
- PATH=$TRAVIS_BUILD_DIR/bin:$PATH
addons:
apt:
packages:
- texlive-base
- texlive-latex-extra # we need this for all the latex package we use, recommended is not enough
- texlive-generic-recommended # .. and more ...
- latex-xcolor # ... and more latex packages
- texlive-fonts-recommended # fonts...
- cm-super # more fonts
- texlive-xetex # latex to pdf converter
- inkscape # for svgs in pdf output
before_install:
- git clone --quiet --depth 1 https://github.com/minrk/travis-wheels travis-wheels
install:
Expand Down
2 changes: 1 addition & 1 deletion nbconvert/exporters/tests/test_pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def test_constructor(self):
self.exporter_class()


@dec.onlyif_cmds_exist('pdflatex')
@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
def test_export(self):
"""Smoke test PDFExporter"""
Expand Down
8 changes: 4 additions & 4 deletions nbconvert/tests/test_nbconvertapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_explicit(self):
assert os.path.isfile('notebook2.py')


@dec.onlyif_cmds_exist('pdflatex')
@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
def test_filename_spaces(self):
"""
Expand All @@ -107,7 +107,7 @@ def test_filename_spaces(self):
assert os.path.isfile('notebook with spaces.pdf')


@dec.onlyif_cmds_exist('pdflatex')
@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
def test_pdf(self):
"""
Expand Down Expand Up @@ -228,7 +228,7 @@ def test_accents_in_filename(self):
self.nbconvert('--log-level 0 --to Python nb1_*')
assert os.path.isfile(u'nb1_análisis.py')

@dec.onlyif_cmds_exist('pdflatex', 'pandoc')
@dec.onlyif_cmds_exist('xelatex', 'pandoc')
def test_filename_accent_pdf(self):
"""
Generate PDFs if notebooks have an accent in their name?
Expand Down Expand Up @@ -352,7 +352,7 @@ def test_convert_from_stdin(self):
assert_not_in('```python', output1) # shouldn't have language
assert_in("```", output1) # but should have fenced blocks

@dec.onlyif_cmds_exist('pdflatex')
@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
def test_linked_images(self):
"""
Expand Down