Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minted from Latex base template #367

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

takluyver
Copy link
Member

It requires a flag to disable a security feature, which we've decided not to use.

Closes gh-350

Alternative to #353

Ping @amueller @JanSchulz @flying-sheep

It requires a flag to disable a security feature, which we've decided
not to use.

Closes jupytergh-350
@takluyver takluyver added this to the 5.0 milestone Aug 18, 2016
@jankatins
Copy link
Contributor

This then "reopens" #335

irkernel/repr right now depends on minted: https://github.com/IRkernel/repr/blob/master/R/repr_function.r#L37 (this is not in then PR in IRkernel/repr#77 which only switches the default to use a r function to highlight)

@takluyver
Copy link
Member Author

Right, it effectively pushes the issue back to IRkernel.

@flying-sheep
Copy link
Contributor

flying-sheep commented Aug 18, 2016

this is not in then PR in IRkernel/repr#77 which only switches the default to use a r function to highlight

it is. i think you misinterpret the code.

repr_latex.function calls repr_function_generic(..., high_wrap = '%s', norm_wrap = minted_wrap, ...), and if highlight == TRUE, the function uses high_wrap instead of norm_wrap. i.e. minted isn’t used.

if we merge IRkernel/repr#77, we have a default that works, and once somebody changes the option, they’ll have to go the route jupyter nbconvert --to=text *.ipynb; pdflatex -shell-escape *.tex

merging both PRs would be the pragmatic solution that “makes the ‘download PDF’ button work”

@takluyver
Copy link
Member Author

Merging this because the test failure emails are getting old, and this failure might be obscuring other failures. I think we have agreement on this, but if we want to do something else, we can always change it later.

@takluyver takluyver merged commit 6d5b01b into jupyter:master Aug 20, 2016
@takluyver takluyver deleted the rm-minted branch August 20, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants