Pretty print color contrasts #240
Comments
tallamjr
added a commit
to tallamjr/nbdime
that referenced
this issue
Feb 4, 2022
Ass addressed in jupyter#240 the headers are printed in BLUE, which is hard to read when using git integration in a dark terminal. This allows for the color to remain the same, but just to brighten it up such that is more readable. Refs: - https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15 modified: prettyprint.py
tallamjr
added a commit
to tallamjr/nbdime
that referenced
this issue
Feb 4, 2022
As addressed in jupyter#240 the headers are printed in BLUE, which is hard to read when using git integration in a dark terminal. This allows for the color to remain the same, but just to brighten it up such that is more readable. Refs: - https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15 modified: prettyprint.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the pretty printed output, the headers are printed in blue. In terminals with black backgrounds, this leads to very poor contrast (blue on black). The green/red/yellow outputs are all OK (at least to my eyes). We should consider if there is another color that would fit better, but that would also work for terminals with light background.
The text was updated successfully, but these errors were encountered: