Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook 6 server extension support (w/tests) #656

Merged
merged 4 commits into from
Apr 22, 2023

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Mar 24, 2023

Fail loudly (but not catastrophically) if trying to load as a server extension for notebook v6, if jupyter_server 2 is installed. It would fail anyways due to base classes being incompatible, but this will produce a clear error message, and stop loading the nbdime handlers.

@fcollonval
Copy link
Collaborator

I got hit by the error about crypto in jupyterlab-git. I fixed the Jest config like that: jupyterlab/jupyterlab-git@8d0f10a

@vidartf
Copy link
Collaborator Author

vidartf commented Apr 12, 2023

codecov seems to have been pulled from PyPI? Or is PyPI having issues?

Adds support for notebook 6 by loudly failing if trying to load nbdime as an nb6 server extension if jupyter_server version >= 2.
node 18, webpack 5, etc.
Try to use a more modern appveyor image, so we get newer git version
@fcollonval
Copy link
Collaborator

fcollonval commented Apr 14, 2023

codecov seems to have been pulled from PyPI? Or is PyPI having issues?

It has been removed https://about.codecov.io/blog/message-regarding-the-pypi-package/

@vidartf vidartf merged commit 691b9c8 into jupyter:master Apr 22, 2023
@vidartf vidartf deleted the nb6 branch April 22, 2023 10:28
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Apr 23, 2023
* Reorder dependencies following setup.py
* Remove no longer needed python-six and python-ipython-genutils [1][2]
* Remove npm from makedepends - not needed for a PyPI tarball as the
  latter includes built frontend artifacts
* jupyter-notebook and python-packaging are needed for notebook 6
  support only [3]
* Drop no longer needed hacks

[1] jupyter/nbdime#586
[2] jupyter/nbdime#618
[3] jupyter/nbdime#656

git-svn-id: file:///srv/repos/svn-community/svn@1448348 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Apr 23, 2023
* Reorder dependencies following setup.py
* Remove no longer needed python-six and python-ipython-genutils [1][2]
* Remove npm from makedepends - not needed for a PyPI tarball as the
  latter includes built frontend artifacts
* jupyter-notebook and python-packaging are needed for notebook 6
  support only [3]
* Drop no longer needed hacks

[1] jupyter/nbdime#586
[2] jupyter/nbdime#618
[3] jupyter/nbdime#656



git-svn-id: file:///srv/repos/svn-community/svn@1448348 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants