Use pseudo-elements instead of border to preserve line height #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: using negative margin does not work because CM6 calculates line height to programmatically set the height of gutter (e.g. line numbers), which does not account for margins.
fcollonval
force-pushed
the
line-spacing
branch
from
3d795e1
to
6f3d08b
Compare
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Merging to reduce multiple rebase / update snapshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674
This PR re-implements chunk borders with pseudo-elements instead of
border-top/border-bottom.