Restore collapsers #701
Restore collapsers #701
Conversation
fcollonval
force-pushed
the
fix/679-CM6-Restore-collapser
branch
from
b45b11f
to
8dd6bc6
Compare
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Kicking the CI |
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
There was a problem hiding this comment.
The windows version retains the lock spacer, while the linux version does not?
There was a problem hiding this comment.
The linux version has ... X unchanged lines ... while Windows version does not have ellipsis?
There was a problem hiding this comment.
@vidartf Indeed that's strange.
|
The issue with divergent snapshots is because one of the updates failed (the Linux one) because between starting the job and finishing it someone pushed another commit to the branch which prevented it from pushing the udpated screenshots https://github.com/jupyter/nbdime/actions/runs/6420290475/job/17432051180. Because the jobs run sequentially the other one did not fail because it already fetched the updated git repo. To prevent inconsistent state we could make the entire job fail if any of them fails. For now: bot please update playwright snapshots |
|
Playwright ubuntu-22.04 snapshots updated. |
|
@krassowski Ok thanks for pointing this. This may be my fault then because I pushed a new commit on the branch. But now the three dots ellipsis does not appear neither on windows nor on linux snapshots. It appears that this change vanishes out. I will restablish it. |
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Issue is fixed, the screenshots are now ok and tests are green. |
| toDOM(view: EditorView) { | ||
| let outer = document.createElement('div'); | ||
| outer.className = 'cm-collapsedLines'; | ||
| outer.textContent = view.state.phrase('...$ unchanged lines...', this.lines); |
There was a problem hiding this comment.
If we want this to look similar to older versions of nbdime, we could simply have this be (...). Maybe having (...) $ unchanged lines ? Mostly subjective taste at this point, so I'm happy to leave the final judgment to you.
There was a problem hiding this comment.
I proposed this mixed version between the previous (...) version and the new text-only one but I don't have a strong opinion on it. Maybe @fcollonval @krassowski have some.
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
fcollonval
force-pushed
the
fix/679-CM6-Restore-collapser
branch
from
90e8a80
to
413e535
Compare
Co-authored-by: Florence Haudin <99649086+HaudinFlorence@users.noreply.github.com>
…-tests snapshots.
fcollonval
force-pushed
the
fix/679-CM6-Restore-collapser
branch
from
413e535
to
36bc9bc
Compare
Fixes #679