Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag and drop #723

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Fix drag and drop #723

merged 6 commits into from
Oct 26, 2023

Conversation

fcollonval
Copy link
Collaborator

@fcollonval fcollonval commented Oct 25, 2023 •
edited
Loading

Fixes #721

It also at least partly addresses #720 as it restores Lumino widgets styling

  • This switches from phosphor convention to lumino convention for CSS and events naming
  • Fix the position of the drag image
    @krassowski I was surprised to have to add .lm-mod-drag-image { left: 0px; top: 0px; }. Is there something to fix upstream or did I missed something?

@fcollonval fcollonval added the bug label Oct 25, 2023
@fcollonval fcollonval changed the title Use lumino and not Phosphor convention Fix drag and drop Oct 25, 2023
@fcollonval fcollonval marked this pull request as ready for review October 25, 2023 16:43
@fcollonval
Copy link
Collaborator Author

bot please update snapshots

@fcollonval
Copy link
Collaborator Author

bot please update playwright snapshots

@github-actions
Copy link
Contributor

Playwright windows-latest snapshots updated.

@fcollonval
Copy link
Collaborator Author

I'll rebase and update the snapshots when the translation PR is in.

@fcollonval
Copy link
Collaborator Author

bot please update playwright snapshots

@github-actions
Copy link
Contributor

Playwright ubuntu-22.04 snapshots updated.

@github-actions
Copy link
Contributor

Playwright windows-latest snapshots updated.

@fcollonval
Copy link
Collaborator Author

bot please update playwright snapshots

@github-actions
Copy link
Contributor

Playwright windows-latest snapshots updated.

@github-actions
Copy link
Contributor

Playwright ubuntu-22.04 snapshots updated.

@fcollonval fcollonval closed this Oct 26, 2023
@fcollonval fcollonval reopened this Oct 26, 2023
@krassowski
Copy link
Member

@krassowski I was surprised to have to add .lm-mod-drag-image { left: 0px; top: 0px; }. Is there something to fix upstream or did I missed something?

I tested it locally and compared with lab/notebook. It seems we should add it in lumino as default; it is not strictly needed in lab nor notebook because the only other children of body are fully positioned and do not take up any space.

@krassowski krassowski mentioned this pull request Oct 26, 2023
Merged
@krassowski
Copy link
Member

I opened jupyterlab/lumino#651. For now I think we can merge this as-is, all worked well locally.

krassowski
krassowski approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit 997be80 into jupyter:master Oct 26, 2023
16 checks passed
@fcollonval fcollonval deleted the fix/721-drag-drop branch October 27, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CM6 tail: Merge view cell drag and drop
2 participants
@fcollonval @krassowski