Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hatch build backend #1669

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 26, 2022

Use hatch and the hatch-jupyter-builder plugin, while still honoring NBGRADER_NO_LAB.

I compared the sdist and the wheel contents before and after using the hatch_jupyter_builder.compare_migration script.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch blink1073/nbgrader/migrate-packaging

@brichet
Copy link
Contributor

brichet commented Sep 26, 2022

Thanks @blink1073
This look like good to me.

We should update the conda recipe after this PR, which doesn't work now anyway : conda-forge/nbgrader-feedstock#56

@blink1073
Copy link
Contributor Author

Sounds good, if you want to make a release I can update the conda recipe.

@brichet brichet merged commit 9a85dc1 into jupyter:main Sep 26, 2022
@brichet
Copy link
Contributor

brichet commented Sep 27, 2022

Sounds good, if you want to make a release I can update the conda recipe.

It's released : https://github.com/jupyter/nbgrader/releases/tag/v0.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants