Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow current working directory for nbgrader config file only #1698

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Oct 28, 2022

This PR is to (re)allow loading configuration file from current working directory.
This feature has been removed from jupyter_core for security reasons (GHSA-pq7m-3gw7-gq5x).

This will fix the tests on extensions which are broken since the last release of jupyter_core.

For what I understand it should only load configuration file for nbgrader, it should not reintroduce the security error.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/nbgrader/fix/config_dir

@jtpio
Copy link
Member

jtpio commented Oct 28, 2022

Thanks @brichet 👍

I think that makes sense if a specific file is explicitly loaded and not any in cwd like it was the case before.

Looks like the jupyter_core advisory has now been published: GHSA-m678-f26j-3hrp

@brichet
Copy link
Contributor Author

brichet commented Oct 28, 2022

Thanks for sharing the correct link.

@brichet brichet merged commit f257042 into jupyter:main Nov 8, 2022
@brichet brichet deleted the fix/config_dir branch November 8, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants