Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traitlets requirement from <5.2.0 to <5.7.0 #1704

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 30, 2022

Updates the requirements on traitlets to permit the latest version.

Release notes

Sourced from traitlets's releases.

v5.6.0

5.6.0

(Full Changelog)

Maintenance and upkeep improvements

Contributors to this release

(GitHub contributors page for this release)

@​blink1073 | @​dependabot | @​maartenbreddels | @​pre-commit-ci | @​rmorshea

Changelog

Sourced from traitlets's changelog.

5.6.0

(Full Changelog)

Maintenance and upkeep improvements

Contributors to this release

(GitHub contributors page for this release)

@​blink1073 | @​dependabot | @​maartenbreddels | @​pre-commit-ci | @​rmorshea

5.5.0

  • Clean up application typing
  • Update tests and docs to use non-deprecated functions
  • Clean up version handling
  • Prep for jupyter releaser
  • Format the changelog

5.4.0

  • Fix version_info
  • Make generated config files more lintable
  • Fix union trait from string
  • Add security.md, and tidelift bage

5.3.0

  • Fix traitlet name in docstring
  • Re-support multiple-alias key for ArgParseConfigLoader

5.2.2

  • Make traitlets.__all__ explicit and validate in test.

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [traitlets](https://github.com/ipython/traitlets) to permit the latest version.
- [Release notes](https://github.com/ipython/traitlets/releases)
- [Changelog](https://github.com/ipython/traitlets/blob/main/CHANGELOG.md)
- [Commits](ipython/traitlets@4.0...v5.6.0)

---
updated-dependencies:
- dependency-name: traitlets
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jupyter/nbgrader/dependabot/pip/traitlets-lt-5.7.0

@brichet brichet merged commit e85cdea into main Nov 30, 2022
@brichet brichet deleted the dependabot/pip/traitlets-lt-5.7.0 branch November 30, 2022 10:13
shreve added a commit to shreve/nbgrader that referenced this pull request Mar 23, 2023
The requirement of a specific traitlets version was first set in commit
35ed7aa to be <5.2 because apparently
5.2 broke tests.

The last time this line was updated was in jupyter#1704, where it was bumped up
to allow the latest version at the time, 5.6, by setting the value to
<5.7. There was an additional change in jupyter#1704 which sets a log level,
but this seems to be backwards compatible.

These changes seem to no longer be relevant as the test suite now passes
with traitlets versions 5.2, 5.7, as well as many others >5. The only
version I found to fail was 5.0.0.

This commit loosens the version requirement to allow these other
versions of the traitlets package which don't cause known conflicts, as
well as allow future minor, but not major version bumps.
brichet pushed a commit that referenced this pull request Mar 23, 2023
The requirement of a specific traitlets version was first set in commit
35ed7aa to be <5.2 because apparently
5.2 broke tests.

The last time this line was updated was in #1704, where it was bumped up
to allow the latest version at the time, 5.6, by setting the value to
<5.7. There was an additional change in #1704 which sets a log level,
but this seems to be backwards compatible.

These changes seem to no longer be relevant as the test suite now passes
with traitlets versions 5.2, 5.7, as well as many others >5. The only
version I found to fail was 5.0.0.

This commit loosens the version requirement to allow these other
versions of the traitlets package which don't cause known conflicts, as
well as allow future minor, but not major version bumps.
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
The requirement of a specific traitlets version was first set in commit
35ed7aa to be <5.2 because apparently
5.2 broke tests.

The last time this line was updated was in jupyter#1704, where it was bumped up
to allow the latest version at the time, 5.6, by setting the value to
<5.7. There was an additional change in jupyter#1704 which sets a log level,
but this seems to be backwards compatible.

These changes seem to no longer be relevant as the test suite now passes
with traitlets versions 5.2, 5.7, as well as many others >5. The only
version I found to fail was 5.0.0.

This commit loosens the version requirement to allow these other
versions of the traitlets package which don't cause known conflicts, as
well as allow future minor, but not major version bumps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Python dependencies maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant