Remove jupyter_notebook_config.json since notebook server is not supported anymore #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@brichet What do you think about this change? |
|
Thanks @lahwaacz. |
…notebook_config.d/nbgrader.json There is already jupyter_server_config.d/nbgrader.json and I don't see why jupyter_notebook_config.json should be any different.
lahwaacz
force-pushed
the
move-jupyter-notebook-config
branch
from
a90d54c
to
8676e0e
Compare
|
@brichet Oh, right. I found a few more NotebookApp instances and removed them too. |
brichet
approved these changes
Sep 12, 2023
brichet
changed the title
|
@lahwaacz I've taken the liberty of renaming the PR for the sake of consistency. |
shreve
pushed a commit
to shreve/nbgrader
that referenced
this pull request
Jul 8, 2024
…orted anymore (jupyter#1807) * Move etc/jupyter/jupyter_notebook_config.json to etc/jupyter/jupyter_notebook_config.d/nbgrader.json There is already jupyter_server_config.d/nbgrader.json and I don't see why jupyter_notebook_config.json should be any different. * Remove all instances of NotebookApp since the code requires Notebook >= 7
AlirezaT99
pushed a commit
to AaltoSciComp/nbgrader
that referenced
this pull request
Aug 6, 2024
…orted anymore (jupyter#1807) * Move etc/jupyter/jupyter_notebook_config.json to etc/jupyter/jupyter_notebook_config.d/nbgrader.json There is already jupyter_server_config.d/nbgrader.json and I don't see why jupyter_notebook_config.json should be any different. * Remove all instances of NotebookApp since the code requires Notebook >= 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already
jupyter_server_config.d/nbgrader.jsonand I don't see whyjupyter_notebook_config.jsonshould be any different.