Default kernel type name pyimport/kernel

jupyter · Oct 31, 2018 · f1a79bf · f1a79bf
1 parent 76ab738
commit f1a79bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/notebook/services/kernels/kernelmanager.py b/notebook/services/kernels/kernelmanager.py
@@ -132,7 +132,7 @@ class MappingKernelManager(LoggingConfigurable):
     def _default_kernel_manager_class(self):
         return "jupyter_client.ioloop.IOLoopKernelManager"
 
-    default_kernel_name = Unicode('python3', config=True,
+    default_kernel_name = Unicode('pyimport/kernel', config=True,
         help="The name of the default kernel to start"
     )
 

diff --git a/notebook/services/kernelspecs/tests/test_kernelspecs_api.py b/notebook/services/kernelspecs/tests/test_kernelspecs_api.py
@@ -9,10 +9,7 @@
 
 pjoin = os.path.join
 
-import requests
-
-from jupyter_client.kernelspec import NATIVE_KERNEL_NAME
-from notebook.utils import url_path_join, url_escape, quote
+from notebook.utils import url_path_join, quote
 from notebook.tests.launchnotebook import NotebookTestBase, assert_http_error
 
 # Copied from jupyter_client.tests.test_kernelspec so updating that doesn't
@@ -85,7 +82,7 @@ def test_list_kernelspecs_bad(self):
 
         model = self.ks_api.list().json()
         assert isinstance(model, dict)
-        self.assertEqual(model['default'], NATIVE_KERNEL_NAME)
+        self.assertEqual(model['default'], 'pyimport/kernel')
         specs = model['kernelspecs']
         assert isinstance(specs, dict)
         # 2: the sample kernelspec created in setUp, and the native Python kernel
@@ -96,7 +93,7 @@ def test_list_kernelspecs_bad(self):
     def test_list_kernelspecs(self):
         model = self.ks_api.list().json()
         assert isinstance(model, dict)
-        self.assertEqual(model['default'], NATIVE_KERNEL_NAME)
+        self.assertEqual(model['default'], 'pyimport/kernel')
         specs = model['kernelspecs']
         assert isinstance(specs, dict)