Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull idle terminals #3868

Closed
clkao opened this issue Aug 21, 2018 · 5 comments · Fixed by #5372
Closed

Cull idle terminals #3868

clkao opened this issue Aug 21, 2018 · 5 comments · Fixed by #5372
Labels
component:Terminal enhancement status:resolved-locked

Comments

@clkao
Copy link

clkao commented Aug 21, 2018

#2963 added shutdown_no_activity_timeout and terminal_last_activity, but it seems there's no way to cull idle terminal right now, which prevent the notebook from being shutdown automatically.

Should we have another pair of cull_idle_timeout cull_interval for terminals?
@takluyver
Copy link
Member

That's probably a good idea.

@adriendelsalle adriendelsalle mentioned this issue Aug 20, 2019
Open
@foxel
Copy link

foxel commented Mar 18, 2020

Is there any update on this feature? Maybe implemented somewhere else?

kevin-bates added a commit to kevin-bates/notebook that referenced this issue Apr 13, 2020
@kevin-bates
Add ability to cull terminals and track last activity
e817a20 
This adds functionality to track a terminal's last activity and
optionally cull terminals that have been inactive for some specified
duration.

Resolves: jupyter#3868
kevin-bates added a commit to kevin-bates/notebook that referenced this issue Apr 13, 2020
@kevin-bates
Add ability to cull terminals and track last activity
57e07e0 
This adds functionality to track a terminal's last activity and
optionally cull terminals that have been inactive for some specified
duration.

Resolves: jupyter#3868
kevin-bates added a commit to kevin-bates/notebook that referenced this issue Apr 14, 2020
@kevin-bates
Add ability to cull terminals and track last activity
deeb1e1 
This adds functionality to track a terminal's last activity and
optionally cull terminals that have been inactive for some specified
duration.

Resolves: jupyter#3868
@kevin-bates kevin-bates mentioned this issue Apr 14, 2020
Merged
@kevin-bates
Copy link
Member

I just noticed @clkao's linked comment in the opening description. Since #5372 creates an application-level terminal manager, we can easily shut down terminals when the Notebook server is stopped (similar to running kernels).

I'll go ahead and add that to the PR. If anyone disagrees, please let me know.

@RaghavendraSingh
Copy link

Hi, Any update on this feature?
Also, until this feature becomes available, is there a workaround for culling terminal sessions?

@kevin-bates
Copy link
Member

PR #5372 was created a few weeks back. I'm hoping to have it reviewed shortly. If you'd like to take it for a spin and report back on that PR, it would be appreciated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component:Terminal enhancement status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to cull terminals and track last activity kevin-bates/notebook
5 participants
@clkao @takluyver @foxel @RaghavendraSingh @kevin-bates