-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set cookie on base_url #2959
set cookie on base_url #2959
Conversation
avoids clobbering cookies when multiple notebook servers are run on one host. Users can override `cookie_options.path = ‘/‘` if they *want* cookies to be shared across notebooks on one host.
We're going to try to release 5.2.1. Should this be included? |
@gnestor I guess this is too late to respond, but this is causing problems on mybinder. It would be great if there's a release made with this :) |
We could do a 5.2.2 and only add this. Sound good? |
@gnestor that would be awesome! |
Sorry I didn't respond promptly the first time around; not keeping up with my GitHub notifications. It would be handy for binder to have this in a patch release. |
Post-thanksgiving, any luck? :) |
@yuvipanda So sorry to put this off. Will release 5.2.2 today 👌 |
@meeseeksdev backport to 5.2.2 |
Update: notebook 5.2.2 is published to pypi (https://pypi.org/project/notebook/5.2.2/) and PR is submitted for conda-forge (conda-forge/notebook-feedstock#25). Please confirm that this fixes the issue on binder and afterwards I will announce the new version on the mail list. |
avoids clobbering cookies when multiple notebook servers are run on one host (e.g. binder)
Users can override
cookie_options.path = '/'
if they want cookies to be shared across notebooks on one host.