-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displays Warning Message if Cookies Not Enabled #3511
Conversation
Thanks, this is looking good. A couple of things:
|
Definitely - we will get started on those changes! 👍 |
Made most of the changes discussed, but I wanted to check in re: websites on cookies before choosing one; I think MDN does a good job of explaining them concisely, although parts of the page go into details that might not really concern users (such as creating cookies, scope, etc.) - if this would be an issue, I can find one that only presents the overview/relevant details. (Also, accidentally clicked "close and comment" earlier - apologies for that!) |
Thanks! I like MDN, but I think it's too technical for this. If people want help enabling cookies, they're probably going to be put off by all the detail. I was thinking more of pages like this one or this one. (Those are just the first ones I found with a quick search; there may well be better ones out there). |
Thanks @ckilcrease and @rosaswaby :-) |
This addresses #2337
Adds a check for cookies using navigator.cookiesEnabled (tested in Chrome 64.0.3282.186, works both when cookies are blocked altogether and when only blocked for localhost:8888). If the user doesn't have cookies enabled, a request to enable cookies appears in body of modal as follows: